Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit-tests for Lucene Byte Vector #990

Conversation

naveentatikonda
Copy link
Member

Description

Add more unit-tests to improve test coverage for Lucene Byte Vector

Check List

  • All tests pass
  • New functionality has been documented.
  • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (afdf125) to head (ad4ce3f).
Report is 286 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #990      +/-   ##
============================================
+ Coverage     85.13%   85.39%   +0.25%     
- Complexity     1141     1147       +6     
============================================
  Files           154      154              
  Lines          4683     4683              
  Branches        423      423              
============================================
+ Hits           3987     3999      +12     
+ Misses          504      495       -9     
+ Partials        192      189       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navneet1v
Copy link
Collaborator

@naveentatikonda are you still working on this PR?

@naveentatikonda
Copy link
Member Author

@naveentatikonda are you still working on this PR?

Will rebase this PR, get it reviewed by our team and close it this week.

@jmazanec15
Copy link
Member

@naveentatikonda can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants